Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing fixes #1508

Merged
merged 3 commits into from Mar 15, 2018
Merged

Routing fixes #1508

merged 3 commits into from Mar 15, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR adds some url converters tests and prevent 2 recurrent bugs:

  • An extra space in uuid converter break the UUID casting
  • Event if the URL is wrong (we don't have unicode slug), prevent unicde in slug resolution to return 400 instead of 404

@noirbizarre noirbizarre added this to the 1.3.1 milestone Mar 15, 2018
@noirbizarre noirbizarre self-assigned this Mar 15, 2018
@noirbizarre noirbizarre requested a review from a team March 15, 2018 15:52
@noirbizarre noirbizarre merged commit 902ea2b into opendatateam:master Mar 15, 2018
@noirbizarre noirbizarre deleted the routing-fixes branch March 15, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees

@noirbizarre noirbizarre

Labels
bug
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte