Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes search result vertical cut off (fix opendatalu/gouvlu#63) #1530

Merged
merged 1 commit into from Mar 26, 2018
Merged

Fixes search result vertical cut off (fix opendatalu/gouvlu#63) #1530

merged 1 commit into from Mar 26, 2018

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre added this to the 1.3.4 milestone Mar 26, 2018
@noirbizarre noirbizarre self-assigned this Mar 26, 2018
@noirbizarre noirbizarre requested a review from a team March 26, 2018 09:39
abulte
abulte approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use em for that?

@noirbizarre
Copy link
Contributor Author

Not in this case, em is relative to the parent font size :/

@noirbizarre noirbizarre merged commit b7226d6 into opendatateam:master Mar 26, 2018
@noirbizarre noirbizarre deleted the search-results-truncation branch March 26, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees

@noirbizarre noirbizarre

Labels
bug user-interface
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte