Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize resource.format #1563

Merged
merged 1 commit into from Apr 3, 2018
Merged

Normalize resource.format #1563

merged 1 commit into from Apr 3, 2018

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Apr 3, 2018

This PR ensures that resource.format is unique across resources by casting it to lower case and trimming it.

Fix #986

@abulte abulte added this to the 1.4.0 milestone Apr 3, 2018
noirbizarre
noirbizarre approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a changelog entry (indicating the need for reindexing)

@abulte abulte force-pushed the fix/resource-format-coherence branch from a03bf9b to ed6240b Compare April 3, 2018 15:24
@abulte abulte force-pushed the fix/resource-format-coherence branch from ed6240b to 2b0e4f8 Compare April 3, 2018 15:25
@abulte abulte merged commit 1b883ea into opendatateam:master Apr 3, 2018
@abulte abulte removed the in progress label Apr 3, 2018
@abulte abulte deleted the fix/resource-format-coherence branch April 3, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noirbizarre noirbizarre noirbizarre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abulte @noirbizarre