Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad UUID 404 #1646

Merged
merged 1 commit into from May 4, 2018
Merged

Bad UUID 404 #1646

merged 1 commit into from May 4, 2018

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented May 4, 2018 •
edited

This PR prevent UUID routin from erroring on bad UUID and consider them as 404 errors.

See: https://sentry.data.gouv.fr/share/issue/d24abc88349c4fa3ae87f2144f1b493e/

@noirbizarre noirbizarre added this to the 1.3.9 milestone May 4, 2018
@noirbizarre noirbizarre self-assigned this May 4, 2018
@noirbizarre noirbizarre requested a review from a team May 4, 2018 16:04
abulte
abulte approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(needs rebase)

@noirbizarre
Consider bad UUID as 404 in routing
e04a4a8 
Fix WWW-DATAGOUVFR-4B66
Fix WWW-DATAGOUVFR-4B67
@noirbizarre noirbizarre merged commit aa8bc1e into opendatateam:1.3 May 4, 2018
@noirbizarre noirbizarre deleted the bad-uuid-404 branch May 4, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees

@noirbizarre noirbizarre

Labels
bug
Projects
None yet
Milestone
1.3.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte