New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad UUID 404 #1646

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Member

noirbizarre commented May 4, 2018

This PR prevent UUID routin from erroring on bad UUID and consider them as 404 errors.

See: https://sentry.data.gouv.fr/share/issue/d24abc88349c4fa3ae87f2144f1b493e/

@noirbizarre noirbizarre added this to the 1.3.9 milestone May 4, 2018

@noirbizarre noirbizarre self-assigned this May 4, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab May 4, 2018

@abulte

abulte approved these changes May 4, 2018

(needs rebase)

Consider bad UUID as 404 in routing
Fix WWW-DATAGOUVFR-4B66
Fix WWW-DATAGOUVFR-4B67

@noirbizarre noirbizarre merged commit aa8bc1e into opendatateam:1.3 May 4, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:bad-uuid-404 branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment