Raven-js/Sentry enhancement #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix WWW-DATAGOUVFR-5ESS Fix WWW-DATAGOUVFR-5JQV Fix WWW-DATAGOUVFR-5FJW Fix WWW-DATAGOUVFR-5HKJ Fix WWW-DATAGOUVFR-5F1R Fix WWW-DATAGOUVFR-5EJJ
abulte
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Raven-js/Sentry integration by:
Errorinheritance with babel so Sentry (and the browser) sees it properly (right type, proper stacktrace)admintoudata.js(because raven-js is also used in front)AuthenticationRequirederrors being volontary thrown but not catched (See: https://sentry.data.gouv.fr/share/issue/1c810673b1dc482780867f30b03c62f4/ or https://sentry.data.gouv.fr/share/issue/6c538eacfc104c0091af960a10cd5b4d/)This PR is the first pass on Raven-js/Sentry tuning and there might be some other improvements available