Show resource type in modal (front) #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noirbizarre
approved these changes
Jun 4, 2018
| }, | ||
| fillResourceType() { | ||
| if (this.resource.type) { | ||
| this.resourceType = resource_types.by_id(this.resource.type).label; |
There was a problem hiding this comment.
Why not a computed property ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do some very convoluted stuff (https://github.com/opendatateam/udata/pull/1714/files#diff-a2d75a95cf3f2bde33208a75029b76a9R76) to make sure it shows up both when opening the modal from the dataset page and via a deeplink.
Ideally there is a way to make this filter await on the loading of
resource_typesbut I did not find how: https://github.com/opendatateam/udata/blob/master/js/components/dataset/filters.js#L28.