Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip gov.uk references when unreachable #1767

Merged
merged 1 commit into from Jun 21, 2018
Merged

Skip gov.uk references when unreachable #1767

merged 1 commit into from Jun 21, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR prevents test suite to fail when references.gov.uk pages are not reachable.

@noirbizarre noirbizarre added this to the 1.4.2 milestone Jun 21, 2018
@noirbizarre noirbizarre self-assigned this Jun 21, 2018
@noirbizarre noirbizarre requested a review from a team June 21, 2018 13:05
abulte
abulte approved these changes Jun 21, 2018
View reviewed changes
udata/tests/dataset/test_dataset_rdf.py Outdated
GOV_UK_REF = 'http://reference.data.gov.uk/id/year/2017'

try:
requests.get(GOV_UK_REF, timeout=0.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.head() maybe

udata/tests/dataset/test_dataset_rdf.py Outdated

try:
requests.get(GOV_UK_REF, timeout=0.1)
GOV_UK_REF_IS_UP = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else :p

@noirbizarre noirbizarre merged commit 5c198fb into opendatateam:master Jun 21, 2018
@noirbizarre noirbizarre deleted the skip-gov-uk branch June 21, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees

@noirbizarre noirbizarre

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte