Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 backports #1769

Merged
merged 16 commits into from Jun 21, 2018
Merged

Python 3 backports #1769

merged 16 commits into from Jun 21, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR backports some Python 3 forward compatible changes.

  • avoid filter and map usage instead of list comprehension
  • explicit encoding handling
  • avoid comparison to None
  • use next() instead of .next() to iterate
  • unhide some implicit casts (in particular search weight which was casted as int and so loosing some precision)

CHANGELOG.md Outdated
@@ -5,6 +5,12 @@
- Sort dataset update frequencies by ascending frequency [#1758](https://github.com/opendatateam/udata/pull/1758)
- Skip gov.uk references tests when site is unreachable [#1767](https://github.com/opendatateam/udata/pull/1767)
- Tests are now run against `local.test` instead of `localhost` to avoid pytest warnings
- Backports some Python 3 froward compatible changes and fixes some bugs [#1769](https://github.com/opendatateam/udata/pull/1769):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/froward/forward/

@noirbizarre noirbizarre merged commit b529416 into opendatateam:master Jun 21, 2018
@noirbizarre noirbizarre deleted the py3-backport branch June 21, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants