Improve usability at new organization creation #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This sounds great. You can add a screenshot (before/after) for cosmetical improvements. It is easier for quick reviews. |
|
Updated with screenshots! :) |
abulte
reviewed
Jun 29, 2018
| @@ -13,9 +13,9 @@ | |||
| <input type="text" name="search" class="form-control" | |||
| :placeholder="_('Search')" v-model="search_query" /> | |||
| <div class="input-group-btn"> | |||
| <button type="submit" name="submit" class="btn btn-warning btn-flat"> | |||
| <div class="btn btn-warning btn-flat"> | |||
There was a problem hiding this comment.
Why did you replace the button tag?
There was a problem hiding this comment.
The button is just reloading the page and you lose all your search criteria when you click on it, it does nothing as the search happens when you are typing so no need for a submit button. ( Users get confused when they click on it, the page reloads and the search gets lost.)
abulte
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
@micael-grilo please add a CHANGELOG entry and this should be good to merge! 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR with a improvement to the search organization button on administration. The search results appear as you type and clicking on the buttons reloads the page unnecessarily causing some confusion to the users, so I've removed this page reloading feature.
It adds also a 'Find or create your organization' button so the user can click on it when no organization results have been found.
Before:
After:
Best!