Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability at new organization creation #1777

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@micael-grilo
Copy link
Contributor

micael-grilo commented Jun 28, 2018

This is a PR with a improvement to the search organization button on administration. The search results appear as you type and clicking on the buttons reloads the page unnecessarily causing some confusion to the users, so I've removed this page reloading feature.

It adds also a 'Find or create your organization' button so the user can click on it when no organization results have been found.

Before:
image

After:
image

Best!

@taniki

This comment has been minimized.

Copy link
Member

taniki commented Jun 29, 2018

Thanks for the PR! This sounds great. You can add a screenshot (before/after) for cosmetical improvements. It is easier for quick reviews.

@micael-grilo

This comment has been minimized.

Copy link
Contributor Author

micael-grilo commented Jun 29, 2018

Updated with screenshots! :)

@@ -13,9 +13,9 @@
<input type="text" name="search" class="form-control"
:placeholder="_('Search')" v-model="search_query" />
<div class="input-group-btn">
<button type="submit" name="submit" class="btn btn-warning btn-flat">
<div class="btn btn-warning btn-flat">

This comment has been minimized.

Copy link
@abulte

abulte Jun 29, 2018

Member

Why did you replace the button tag?

This comment has been minimized.

Copy link
@micael-grilo

micael-grilo Jun 29, 2018

Author Contributor

The button is just reloading the page and you lose all your search criteria when you click on it, it does nothing as the search happens when you are typing so no need for a submit button. ( Users get confused when they click on it, the page reloads and the search gets lost.)

@abulte

abulte approved these changes Jun 29, 2018

Copy link
Member

abulte left a comment

@micael-grilo please add a CHANGELOG entry and this should be good to merge! 💪

@taniki taniki merged commit 640ffb6 into opendatateam:master Jul 5, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

taniki added a commit that referenced this pull request Jul 5, 2018

@micael-grilo micael-grilo deleted the amagovpt:feature_find-org-usability branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.