Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources reorder (registered extras validation logic) #1796

Merged
merged 4 commits into from Jul 20, 2018

Conversation

Projects
None yet
2 participants
@abulte
Copy link
Member

abulte commented Jul 18, 2018

Fix #1794

Well, this was a hell of a bug hunt 馃槄

I finally fixed it by using a bare WTForm for registered extras validation instead of one from flask-wtf which would run into this logic https://github.com/lepture/flask-wtf/blob/9cb0ac619f79a702254e1ad248ea8e15e5691d92/flask_wtf/form.py#L64 and fail because we have a list of ids on this route.

abulte added some commits Jul 18, 2018

@abulte abulte requested a review from opendatateam/etalab Jul 18, 2018

@abulte abulte merged commit f6f8363 into opendatateam:master Jul 20, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@abulte abulte deleted the abulte:fix/order-resources branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.