Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources reorder (registered extras validation logic) #1796

Merged
merged 4 commits into from Jul 20, 2018

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Jul 18, 2018

Fix #1794

Well, this was a hell of a bug hunt 馃槄

I finally fixed it by using a bare WTForm for registered extras validation instead of one from flask-wtf which would run into this logic https://github.com/lepture/flask-wtf/blob/9cb0ac619f79a702254e1ad248ea8e15e5691d92/flask_wtf/form.py#L64 and fail because we have a list of ids on this route.

@abulte abulte requested a review from a team July 18, 2018 12:34
@abulte abulte merged commit f6f8363 into opendatateam:master Jul 20, 2018
@abulte abulte deleted the fix/order-resources branch July 20, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reorder resources w/ registered extras
2 participants