Harvest config admin #1812
Merged
Harvest config admin #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Aug 1, 2018
| }, | ||
| placeholder() { | ||
| if (!this.key || !this.choices) return; | ||
| return this.choices.find(c => c.key ==this.key).description; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #1716 starts exposing the harvester configuration (only filtering right now) in the admin form.
Features
Only display filters if backend supports it
Without filtering support
With filtering support
Backends specific filters and localised wordings
Each backend has the responsibility to expose its handled filters and provide translated labels (See #1716)
Side-effects
This feature rely on fields change detection so form fields gain change detection in this PR