Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OEmbed works with CDN and fixes some static serialization #1815

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Aug 2, 2018

This PR:

  • ensures OEmbed (and legacy widget) compatibility with external CDN
  • fixes some static URL serialization cases

By the way, every existing OEmbed/legacy widget integration still works because the assets are still reachable on the old URL.

@noirbizarre noirbizarre self-assigned this Aug 2, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 2, 2018

@noirbizarre noirbizarre added this to the 1.5.1 milestone Aug 2, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:cdn-embed branch from ba9e643 to df546ec Aug 2, 2018

@abulte

abulte approved these changes Aug 2, 2018

Copy link
Member

left a comment

Also needs a PR to http://doc.data.gouv.fr I guess?

@noirbizarre

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

Yes, I will 👍

@noirbizarre noirbizarre merged commit ef8eb12 into opendatateam:1.5 Aug 2, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:cdn-embed branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.