Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure OEmbed works with CDN and fixes some static serialization #1815

Merged
merged 1 commit into from Aug 2, 2018
Merged

Ensure OEmbed works with CDN and fixes some static serialization #1815

merged 1 commit into from Aug 2, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR:

  • ensures OEmbed (and legacy widget) compatibility with external CDN
  • fixes some static URL serialization cases

By the way, every existing OEmbed/legacy widget integration still works because the assets are still reachable on the old URL.

@noirbizarre noirbizarre self-assigned this Aug 2, 2018
@noirbizarre noirbizarre requested a review from a team August 2, 2018 15:36
@noirbizarre noirbizarre added this to the 1.5.1 milestone Aug 2, 2018
abulte
abulte approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a PR to http://doc.data.gouv.fr I guess?

@noirbizarre
Copy link
Contributor Author

Yes, I will 👍

@noirbizarre noirbizarre merged commit ef8eb12 into opendatateam:1.5 Aug 2, 2018
@noirbizarre noirbizarre deleted the cdn-embed branch August 2, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees

@noirbizarre noirbizarre

Labels
bug regression
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte