Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent word breaking when wrapping discussions messages (fix #1820) #1822

Merged

Conversation

@noirbizarre
Copy link
Member

commented Aug 6, 2018

This PR change the discussions word wrapping rule and prevent word to be breaked:

  • layout has been a little bit refactored so all flexbox constraints apply (width in particular)
  • scoped style attribute has been removed allowing style to apply on Markdown
  • word-wrap and word-break are back to normal in the message body
  • set word-wrap: break-word and word-break: break-all on message body anchors
  • make pre > code scroll horizontal in case of overflow

Desktop

screenshot-data xps-2018 08 06-18-34-37

Mobile

screenshot-data xps-2018 08 06-17-52-37

Notes

Fixes #1820
Fixes #1747

@noirbizarre noirbizarre added this to the 1.5.2 milestone Aug 6, 2018
@noirbizarre noirbizarre self-assigned this Aug 6, 2018
@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 6, 2018
@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1820-prevent-word-breaking branch from bb12da7 to 2b3b7c8 Aug 6, 2018
@taniki
taniki approved these changes Aug 6, 2018
@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1820-prevent-word-breaking branch 3 times, most recently from 80b0690 to a88c124 Aug 6, 2018
@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1820-prevent-word-breaking branch from a88c124 to 3cedf73 Aug 6, 2018
@noirbizarre noirbizarre merged commit e612bb6 into opendatateam:1.5 Aug 6, 2018
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:gh#1820-prevent-word-breaking branch Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.