Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent word breaking when wrapping discussions messages (fix #1820) #1822

Merged
merged 1 commit into from Aug 6, 2018
Merged

Prevent word breaking when wrapping discussions messages (fix #1820) #1822

merged 1 commit into from Aug 6, 2018

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Aug 6, 2018

This PR change the discussions word wrapping rule and prevent word to be breaked:

  • layout has been a little bit refactored so all flexbox constraints apply (width in particular)
  • scoped style attribute has been removed allowing style to apply on Markdown
  • word-wrap and word-break are back to normal in the message body
  • set word-wrap: break-word and word-break: break-all on message body anchors
  • make pre > code scroll horizontal in case of overflow

Desktop

screenshot-data xps-2018 08 06-18-34-37

Mobile

screenshot-data xps-2018 08 06-17-52-37

Notes

Fixes #1820
Fixes #1747

@noirbizarre noirbizarre added this to the 1.5.2 milestone Aug 6, 2018
@noirbizarre noirbizarre self-assigned this Aug 6, 2018
@noirbizarre noirbizarre requested a review from a team August 6, 2018 14:34
@noirbizarre noirbizarre merged commit e612bb6 into opendatateam:1.5 Aug 6, 2018
@noirbizarre noirbizarre deleted the gh#1820-prevent-word-breaking branch August 6, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants