Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin duplicate notifications #1831

Merged
merged 1 commit into from Aug 17, 2018
Merged

Fix admin duplicate notifications #1831

merged 1 commit into from Aug 17, 2018

Conversation

noirbizarre
Copy link
Contributor

This pull-request ensure notifications are displayed once.
Since we have changed the notification format (which are now toasts), there is nomore need to display notifications into modals, they just needs to be displayed over the modal backdrop.

So, this PR:

  • removes modal notifications
  • set the z-index to be over modals
  • ensure stacked notifications all have the same width

screenshot-data xps-2018 08 17-12-48-52

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 17, 2018
@noirbizarre noirbizarre self-assigned this Aug 17, 2018
@noirbizarre noirbizarre requested a review from a team August 17, 2018 11:02
@noirbizarre noirbizarre merged commit c1e41c5 into opendatateam:master Aug 17, 2018
@noirbizarre noirbizarre deleted the admin-duplicate-notifs branch August 17, 2018 11:21
@noirbizarre noirbizarre mentioned this pull request Aug 24, 2018
Merged
@noirbizarre noirbizarre modified the milestones: 1.6.0, 1.5.3 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniki taniki taniki approved these changes

Assignees

@noirbizarre noirbizarre

Labels
admin bug user experience
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @taniki