Fix missing dataset title on client-side card listing #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taniki
approved these changes
Aug 17, 2018
| @@ -268,7 +269,7 @@ export class List extends Base { | |||
| } | |||
|
|
|||
| on_fetched(data) { | |||
| this.items = data.obj; | |||
| this.items = this.model ? data.obj.map(o => new this.model({data: o})) : data.obj; | |||
There was a problem hiding this comment.
this looks like some black magic code having a wider scope than the PR desc
There was a problem hiding this comment.
Details on how and why added in the description
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing dataset title on editorial home datasets.
Explanation
full_titleisDatasetobject computed property (it'stitle+acronymif present).Everywhere but here this is a list of
Datasetobject instances which is given as parameter.To fix this, this PR allows to cast js
Listobjects with an optionnalmodeloption in constructor.Before
After