Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent front views from hitting swagger.json #1838

Merged
merged 1 commit into from Aug 21, 2018
Merged

Prevent front views from hitting swagger.json #1838

merged 1 commit into from Aug 21, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR ensures that front views don't not rely on swagger.json

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 21, 2018
@noirbizarre noirbizarre requested a review from a team August 21, 2018 08:46
abulte
abulte reviewed Aug 21, 2018
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test both on open from dataset page and direct open (deeplink)? I remember this was a challenge.

@noirbizarre
Copy link
Contributor Author

Yep, I saw the comment so I tested both and it work on both thanks to computed properties.

@abulte
Copy link
Contributor

abulte commented Aug 21, 2018

(Sorry for pulling this damn swagger.json in the first place ;-))

@noirbizarre
Copy link
Contributor Author

No worries, the initial mistake of relying on swagger.json for admin API calls is mine 😉

@noirbizarre noirbizarre merged commit ed64b62 into opendatateam:master Aug 21, 2018
@noirbizarre noirbizarre deleted the no-front-swagger branch August 21, 2018 09:40
@noirbizarre noirbizarre mentioned this pull request Aug 24, 2018
Merged
@noirbizarre noirbizarre modified the milestones: 1.6.0, 1.5.3 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
performance user experience
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte