Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unicode errors on unicode URLs validation error #1844

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Aug 23, 2018

This PR prevent Unicode errors to hide validation error on unicode URLs (appearing as Internal Server Errors for client instead of explicit error)

@noirbizarre noirbizarre added the bug label Aug 23, 2018

@noirbizarre noirbizarre added this to the 1.5.3 milestone Aug 23, 2018

@noirbizarre noirbizarre self-assigned this Aug 23, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 23, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:uris-unicode-error branch from e8647c5 to 84450d7 Aug 23, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:uris-unicode-error branch from 84450d7 to 591d3db Aug 23, 2018

@taniki

taniki approved these changes Aug 23, 2018

@noirbizarre noirbizarre merged commit 709e6fc into opendatateam:1.5 Aug 23, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:uris-unicode-error branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.