add organization and user names on dataset pages #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noirbizarre
reviewed
Aug 23, 2018
There was a problem hiding this comment.
The fact user was not displayed into the sidebar but only below the title was intentional:
- allowed to mark a real difference between users and organizations (in particular when they should be publishing as an organization)
- it was an incentive to publish as org
- it raise the spam cost (you need to publish as org to have a logo and a producer description on thepage)
We need to discuss this (I have arguments for both cases but we needs to be sure this is really what we want)
NB: adds some screenshots
| @@ -0,0 +1,34 @@ | |||
| <a href="{{ url_for('users.show', user=user, _external=True) }}" | |||
| title="{{ user.name }}"> | |||
| <img src="{{ user.logo|placeholder('organization') }}" | |||
There was a problem hiding this comment.
Placeholder should be user
| <h4>{{ user.first_name }} {{ user.last_name }}</h4> | ||
|
|
||
| <div class="caption text-left"> | ||
| {% if user.description %} |
| alt="{{ user.name }}" class="organization-logo producer img-responsive"/> | ||
| </a> | ||
|
|
||
| <h4>{{ user.first_name }} {{ user.last_name }}</h4> |
|
Currently, there is UI consistency issues:
The spam and org incentive issues seem to be strongly related to data.gouv.fr situation and might strongly impact deployment of other generic open data platform (e.g. private and non-gov instances) |
noirbizarre
approved these changes
Aug 23, 2018
|
I agree on both point but this was explicitely asked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1836