Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add organization and user names on dataset pages #1847

Merged
merged 6 commits into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@taniki
Copy link
Member

taniki commented Aug 23, 2018

fix #1836

@noirbizarre
Copy link
Member

noirbizarre left a comment

The fact user was not displayed into the sidebar but only below the title was intentional:

  • allowed to mark a real difference between users and organizations (in particular when they should be publishing as an organization)
  • it was an incentive to publish as org
  • it raise the spam cost (you need to publish as org to have a logo and a producer description on thepage)

We need to discuss this (I have arguments for both cases but we needs to be sure this is really what we want)

NB: adds some screenshots

@@ -0,0 +1,34 @@
<a href="{{ url_for('users.show', user=user, _external=True) }}"
title="{{ user.name }}">
<img src="{{ user.logo|placeholder('organization') }}"

This comment has been minimized.

Copy link
@noirbizarre

noirbizarre Aug 23, 2018

Member

Placeholder should be user

<h4>{{ user.first_name }} {{ user.last_name }}</h4>

<div class="caption text-left">
{% if user.description %}

This comment has been minimized.

Copy link
@noirbizarre

noirbizarre Aug 23, 2018

Member

user.about ?

alt="{{ user.name }}" class="organization-logo producer img-responsive"/>
</a>

<h4>{{ user.first_name }} {{ user.last_name }}</h4>

This comment has been minimized.

Copy link
@noirbizarre

noirbizarre Aug 23, 2018

Member

{{ user.fullname }}

fix
@taniki

This comment has been minimized.

Copy link
Member Author

taniki commented Aug 23, 2018

Currently, there is UI consistency issues:

  • between a dataset from an org and a regular author
  • between templates for reuse and dataset

The spam and org incentive issues seem to be strongly related to data.gouv.fr situation and might strongly impact deployment of other generic open data platform (e.g. private and non-gov instances)

@noirbizarre
Copy link
Member

noirbizarre left a comment

Approved technically. We still needs to be sure we want to make the user change

@noirbizarre

This comment has been minimized.

Copy link
Member

noirbizarre commented Aug 23, 2018

I agree on both point but this was explicitely asked

taniki and others added some commits Aug 23, 2018

@taniki taniki merged commit fe957be into opendatateam:master Aug 23, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.