Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize uploaded filenames #1852

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Aug 24, 2018

This PR normalizes uploaded files names to avoid:

  • encoding issues in udata (or elsewhere)
  • filesystem incompatibilities
  • ugly URLs

So an uploaded file named My Ügly Nämé.TXT will be stored and visible as my-ugly-name.txt, no encoding issue on anywhere (only ASCII), no issue with filesystem (no spaces, no special chars), same filename on filesystem and in URL.

@noirbizarre noirbizarre added this to the 1.5.3 milestone Aug 24, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 24, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:normalize-uploaded-files branch from 623a46e to d80d3a4 Aug 24, 2018

@abulte

abulte approved these changes Aug 27, 2018

Copy link
Member

abulte left a comment

👌

No need to migrate existing data?

@noirbizarre noirbizarre force-pushed the noirbizarre:normalize-uploaded-files branch from d80d3a4 to f8482b4 Aug 27, 2018

@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 27, 2018

No, it will only apply to newly uploaded files

@noirbizarre noirbizarre merged commit f883dd8 into opendatateam:1.5 Aug 27, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:normalize-uploaded-files branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.