Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use left and right arrows instead of hamburger icon for admin sidebar #1855

Merged

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Aug 27, 2018

This PR use less confusing visual symbols for admin sidebar collapse button

Before

Expanded Collapsed
screenshot-data xps-2018 08 27-10-38-38 screenshot-data xps-2018 08 27-10-38-55

After

Expanded Collapsed
screenshot-data xps-2018 08 27-10-37-26 screenshot-data xps-2018 08 27-10-37-46

Fixes #1340

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 27, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 27, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1340-admin-toggle-icon branch from b1fc69f to aa2d45a Aug 27, 2018

@abulte

abulte approved these changes Aug 27, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1340-admin-toggle-icon branch from aa2d45a to 05e8508 Aug 27, 2018

@noirbizarre noirbizarre merged commit 6f17ccd into opendatateam:master Aug 27, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:gh#1340-admin-toggle-icon branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.