Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken sorts on organizations datasets list in admin #1873

Merged
merged 3 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@abulte
Copy link
Member

commented Sep 5, 2018

Sort args passed by the dataset-list component are made for the search index, not DB. So I created a mapping from one to the other. This feels like a hack, but at least we're not duplicating the component code. Maybe there is a way to do this with the arg parser?

Fix #1869

@abulte abulte requested a review from opendatateam/etalab Sep 5, 2018

@abulte abulte merged commit 294e49d into opendatateam:master Sep 7, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@abulte abulte deleted the abulte:gh-#1869-admin-org-ds-sort branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.