Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional harvest backend features #1875

Merged
merged 4 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Sep 6, 2018

This pull request allows harvest backends to expose their optional features and allows users to toggle them from the admin interface.

Harvest backend from "Features" section (only when revelant)

screenshot-data xps-2018 09 06-12-56-29

More details with description field

screenshot-data xps-2018 09 06-12-57-47

@noirbizarre noirbizarre added this to the 1.6.0 milestone Sep 6, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Sep 6, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:harvest-features branch 3 times, most recently from b1c98d0 to 02c71be Sep 6, 2018

@abulte

abulte approved these changes Sep 7, 2018

@@ -5,6 +5,7 @@
### New features

- Harvest sources are now filterable through the harvest source create/edit admin form [#1812](https://github.com/opendatateam/udata/pull/1812)
- Harvest sources can now enabled or disable some optionnal backend features [#1875](https://github.com/opendatateam/udata/pull/1875)

This comment has been minimized.

Copy link
@abulte

abulte Sep 7, 2018

Member

s/enabled/enable/

if (this.hasFeatures) {
config.features = this.$refs.features.reduce((obj, vm) => {
obj[vm.key] = vm.value
return obj

This comment has been minimized.

Copy link
@abulte

abulte Sep 7, 2018

Member

missing ; on both lines I think

@noirbizarre noirbizarre force-pushed the noirbizarre:harvest-features branch from 02c71be to d500b1e Sep 7, 2018

@noirbizarre noirbizarre merged commit 1491b6d into opendatateam:master Sep 7, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:harvest-features branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.