Optional harvest backend features #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Sep 7, 2018
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### New features | |||
|
|
|||
| - Harvest sources are now filterable through the harvest source create/edit admin form [#1812](https://github.com/opendatateam/udata/pull/1812) | |||
| - Harvest sources can now enabled or disable some optionnal backend features [#1875](https://github.com/opendatateam/udata/pull/1875) | |||
| if (this.hasFeatures) { | ||
| config.features = this.$refs.features.reduce((obj, vm) => { | ||
| obj[vm.key] = vm.value | ||
| return obj |
There was a problem hiding this comment.
missing ; on both lines I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows harvest backends to expose their optional features and allows users to toggle them from the admin interface.
Harvest backend from "Features" section (only when revelant)
More details with description field