Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest preview improvements #1888

Merged
merged 5 commits into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Sep 14, 2018

This pull requests fixes some bugs on harvest preview:

  • ensure that the harvest source edit form preview is done against the current form content instead of the stored sourceconfig
  • prevent some unicode errors in harvest error handling

@noirbizarre noirbizarre added this to the 1.6.0 milestone Sep 14, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Sep 14, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:preview-improvements branch from c9a3151 to 14cc659 Sep 14, 2018

@noirbizarre noirbizarre changed the title Preview improvements Harvest preview improvements Sep 14, 2018

@abulte

abulte approved these changes Sep 17, 2018

Copy link
Member

left a comment

💪 Regarding unicode handling of errors, did you test with http://data.montpellier3m.fr/? I noticed it was failing w/ unicode errors and even tried to fix them to no avail.

},
'form:change': function(form) {
if (form.validate()) {
this.$dispatch('harvest:source:form:changed', this.serialize())

This comment has been minimized.

Copy link
@abulte

abulte Sep 17, 2018

Member

missing ;

@noirbizarre noirbizarre force-pushed the noirbizarre:preview-improvements branch from 14cc659 to f9e6451 Sep 17, 2018

@noirbizarre noirbizarre merged commit e2e690d into opendatateam:master Sep 17, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:preview-improvements branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.