Api specs fixes #1898
Merged
Api specs fixes #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Sep 27, 2018
|
I think we should. In this PR or another ? |
|
@noirbizarre in this PR if you have time I think it's OK |
|
Added validation testing. ( |
abulte
approved these changes
Sep 28, 2018
udata/api/commands.py
Outdated
| schema = json.loads(json.dumps(api.__schema__)) | ||
| try: | ||
| schemas.validate(schema) | ||
| success('API specificationsare valid') |
There was a problem hiding this comment.
s/specificationsare/specifications are/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of
swagger.jsonAPI specs bugs allowing it to validate and so being able to use swagger tools that weren't working (like the new version of Swagger UI).Some fixes are on the
flask-restplusside so it has been updated with it