Allow to restore assets after being deleted ( datasets, organizations and reuses ). #1901
Conversation
| }, | ||
| methods: { | ||
| confirm() { | ||
| var restore_dataset = this.dataset; |
There was a problem hiding this comment.
Use const instead of var because we are trying to use ES6 as much as possible
| }, | ||
| methods: { | ||
| confirm() { | ||
| var restore_organization = this.organization; |
| }, | ||
| methods: { | ||
| confirm() { | ||
| var restore_reuse = this.reuse; |
js/views/dataset.vue
Outdated
| @@ -203,6 +213,12 @@ export default { | |||
| {dataset: this.dataset} | |||
| ); | |||
| }, | |||
| confirm_restore() { | |||
| var m = this.$root.$modal( | |||
There was a problem hiding this comment.
No need to store the reference m, it's not used later.
| @@ -258,6 +274,8 @@ export default { | |||
| class: 'danger', | |||
| label: this._('Deleted') | |||
| }]; | |||
| } else { | |||
| this.badges = []; | |||
There was a problem hiding this comment.
I don't think this is related to this pull-request. Remove it or submit another one for this case
There was a problem hiding this comment.
The purpose of this line is to clear the "Deleted" red badge.
There was a problem hiding this comment.
OK I understand 👍
But on some datasets/reuses/organization, there is more than one badge (more than only the deleted badge), you may need to do some filtering to only remove the deleted badge
| @@ -189,6 +205,8 @@ export default { | |||
| class: 'danger', | |||
| label: this._('Deleted') | |||
| }]; | |||
| } else { | |||
| this.badges = []; | |||
| API.organizations.update_organization( | ||
| {org: this.organization.id, payload: restore_organization}, | ||
| (response) => { | ||
| this.organization.fetch(); |
There was a problem hiding this comment.
To avoid an extra request, you can directly use the response payload to update the organization: this.organization.on_fetched(reponse)
| restore_dataset.deleted = null; | ||
| API.datasets.update_dataset({dataset: this.dataset.id, payload: restore_dataset}, | ||
| (response) => { | ||
| this.dataset.fetch(); |
There was a problem hiding this comment.
To avoid an extra request, you can directly use the response payload to update the dataset: this.dataset.on_fetched(reponse)
| restore_reuse.deleted = null; | ||
| API.reuses.update_reuse({reuse: this.reuse.id, payload: restore_reuse}, | ||
| (response) => { | ||
| this.reuse.fetch(); |
There was a problem hiding this comment.
To avoid an extra request, you can directly use the response payload to update the reuse: this.reuse.on_fetched(reponse)
Context:
When I delete an asset ( dataset, organization, reuse), I want to be able to restore it.
Resume:
Assets can be accidentally deleted, and there's no way to easily restore them, neither through API or through Admin area. This PR adds:
Ability to restore a asset through API:
-- Sending a POST with the deleted field Empty ("deleted:"null") will restore the asset.
Change Admin Area to accommodate this new feature.
-- In admin area you can now easily restore an asset that was deleted.