Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form events not bubbling (and harvester config being hidden) #1914

Merged

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Oct 11, 2018

This PR fix an issue with form events: some handlers were preventing the events from continuing to bubble up.
As a side-effect, the harvester config was never displayed.

@noirbizarre noirbizarre added this to the 1.6.1 milestone Oct 11, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 11, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:fix-form-events-bubbling branch from 60cdfa8 to d83384e Oct 11, 2018

@abulte

abulte approved these changes Oct 11, 2018

@noirbizarre noirbizarre merged commit 066f60f into opendatateam:master Oct 11, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:fix-form-events-bubbling branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.