Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some external assets handling cases #1918

Merged
merged 1 commit into from Oct 16, 2018
Merged

Fix some external assets handling cases #1918

merged 1 commit into from Oct 16, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR fixes some external assets cases:

  • sometimes external keyword was ignored
  • sometimes it didn't exists

This mostly fixes oembed cards.

@noirbizarre noirbizarre requested a review from a team October 15, 2018 09:53
@noirbizarre noirbizarre added this to the 1.6.2 milestone Oct 15, 2018
abulte
abulte reviewed Oct 15, 2018
View reviewed changes
udata/assets.py Show resolved Hide resolved
udata/assets.py Show resolved Hide resolved
@noirbizarre noirbizarre merged commit 1b98313 into opendatateam:master Oct 16, 2018
@noirbizarre noirbizarre deleted the external-assets-fixes branch October 16, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte