Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some external assets handling cases #1918

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Oct 15, 2018

This PR fixes some external assets cases:

  • sometimes external keyword was ignored
  • sometimes it didn't exists

This mostly fixes oembed cards.

@noirbizarre noirbizarre added the bug label Oct 15, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 15, 2018

@noirbizarre noirbizarre added this to the 1.6.2 milestone Oct 15, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:external-assets-fixes branch from 3592fe4 to c916b3c Oct 15, 2018

Show resolved Hide resolved udata/assets.py
Show resolved Hide resolved udata/assets.py
Show resolved Hide resolved udata/assets.py

@noirbizarre noirbizarre force-pushed the noirbizarre:external-assets-fixes branch from c916b3c to bfbe611 Oct 15, 2018

@abulte

abulte approved these changes Oct 16, 2018

@noirbizarre noirbizarre merged commit 1b98313 into opendatateam:master Oct 16, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:external-assets-fixes branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.