Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error on focus in calendar #1937

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Oct 26, 2018

Prevent errors on calendar focus when there is nothing to focus.

@noirbizarre noirbizarre added this to the 1.6.2 milestone Oct 26, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 26, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:fix-calendar-focus branch from 7c2665b to ab1da25 Oct 26, 2018

@abulte

abulte approved these changes Oct 26, 2018

@@ -10,6 +10,7 @@
- Harvest items can now match `source.id` before `source.domain` — no more duplicates when changing an harvester URL [#1923](https://github.com/opendatateam/udata/pull/1923)
- Ensure image picker/cropper only allows images [#1925](https://github.com/opendatateam/udata/pull/1925)
- Make tags min and max length configurable and ensure admin takes its configuration from the backend [#1935](https://github.com/opendatateam/udata/pull/1935)
- Prevent errors when the is no date available to focus in the calendar [#1937](https://github.com/opendatateam/udata/pull/1937)

This comment has been minimized.

Copy link
@abulte

abulte Oct 26, 2018

Member

S/the/there/ s/to focus/to focus on/

@noirbizarre noirbizarre force-pushed the noirbizarre:fix-calendar-focus branch from ab1da25 to 460d2ab Oct 26, 2018

@noirbizarre noirbizarre merged commit a4d5832 into opendatateam:master Oct 26, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:fix-calendar-focus branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.