Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvest preview in edit form not taking configuration (features and filters) #1996

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Jan 25, 2019

This PR fix the lack of change events on harvest config form and so fix the missing configuration in the harvest edit form preview

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 25, 2019

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 25, 2019

@noirbizarre noirbizarre force-pushed the noirbizarre:harvest-edit-preview branch from 71e467e to c13ad27 Jan 25, 2019

@abulte

abulte approved these changes Jan 25, 2019

Show resolved Hide resolved js/views/harvester-edit.vue Outdated

@noirbizarre noirbizarre force-pushed the noirbizarre:harvest-edit-preview branch from c13ad27 to 2e869aa Jan 25, 2019

@noirbizarre noirbizarre merged commit 2fba14d into opendatateam:master Jan 25, 2019

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:harvest-edit-preview branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.