Bugfix/typos #2023
Merged
Bugfix/typos #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a few typos.
- optional => optionnal
- optionnal => optional - optionnaly => optionally No function or variable has been changed in this commit.
The function's name is not used anywhere else in the codebase.
- UData => uData - Optionnal => Optional - Ex => E.g. And a few more tiny fixes.
abulte
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Looks good! A few hurdles before merging:
- please close Fixing a few typos in the documentation and UI/translation strings #2022
- please add the link to this PR in the CHANGELOG
- please use
fix #2021in the PR description to auto-close the associated issue when merged
Thanks!
abulte
suggested changes
Feb 4, 2019
|
I've done the requested updates, I hope we're all set now. Thanks for the careful and detailed guidance! |
abulte
approved these changes
Feb 4, 2019
|
Done, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the directions proposed in #2022
fix #2021