Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/typos #2023

Merged
merged 10 commits into from Feb 4, 2019

Conversation

@bzg
Copy link
Contributor

commented Feb 3, 2019

Follow the directions proposed in #2022

fix #2021

bzg added 7 commits Feb 3, 2019
- optional => optionnal
- optionnal => optional
- optionnaly => optionally

No function or variable has been changed in this commit.
The function's name is not used anywhere else in the codebase.
- UData => uData
- Optionnal => Optional
- Ex => E.g.

And a few more tiny fixes.
@abulte
abulte approved these changes Feb 4, 2019
Copy link
Member

left a comment

Looks good! A few hurdles before merging:

  • please close #2022
  • please add the link to this PR in the CHANGELOG
  • please use fix #2021 in the PR description to auto-close the associated issue when merged

Thanks!

Copy link
Member

left a comment

I missed something: renaming versioning.md has some consequences:

  • mkdocs.yml should be updated
  • there's a link in the CHANGELOG the /versionning that should be renamed
@bzg

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

I've done the requested updates, I hope we're all set now. Thanks for the careful and detailed guidance!

@abulte
abulte approved these changes Feb 4, 2019
Copy link
Member

left a comment

Looks good! You can merge now if you can, if not tell me and I will.

@bzg bzg merged commit f6dcbb5 into opendatateam:master Feb 4, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@bzg

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Done, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.