New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure deleted user slug is pseudonymized too (fix #2016) #2049

Merged

noirbizarre merged 1 commit into opendatateam:master from noirbizarre:deleted-user-slug

Feb 26, 2019

Contributor

noirbizarre commented Feb 25, 2019 •

edited

This PR fixes #2016 by pseudonymizing the slug too on deletion (will be deleted-XXX where XXX is sequential)

Possible alternatives:

use a hash instead of deleted
user the user ID instead of deleted
add a hash as suffix of deleted (ie. deleted-ae7f89)
add a timestamp as suffix (ie. deleted-2019-02-25 but collision are still handled by SlugField so in case of multiple deletion it will be deleted-2019-02-25-1, deleted-2019-02-25-2....)

noirbizarre added the bug label

noirbizarre added this to the 1.6.5 milestone

noirbizarre requested a review from a team

February 25, 2019 19:39


          Ensure deleted user slug is pseudonymized too (fix #2016)

774a31b

noirbizarre merged commit 36f61f6 into opendatateam:master

noirbizarre deleted the deleted-user-slug branch

February 26, 2019 14:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment