Fix harvest job status update #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Mar 27, 2019
Fix NEXT-DATAGOUVFR-18QF Fix NEXT-DATAGOUVFR-8W Fix WWW-DATAGOUVFR-19PN Fix WWW-DATAGOUVFR-NS6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that harvest jobs status updates are applied to the right job and prevent harvest jobs from being stuck in the
initializedstate.In order to allow workers to finish processing tasks submitted with the source ID, this PR create new tasks and deprecate the old ones:
harvest_job_item(job_id, item_id)harvest_item(source_id, item_id)harvest_job_finalize(results, job_id)harvest_finalize(results, source_id)The old tasks do the following:
Fixes this kind of harvest issues: