Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geozones 2019 #2140

Merged
merged 6 commits into from Jul 3, 2019
Merged

Geozones 2019 #2140

merged 6 commits into from Jul 3, 2019

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented May 13, 2019

This PR:

  • ensures that only the latest version of a spatial zone is indexed
  • ensures that the spatial migrate commands works with any levels/any country
  • fixes the spatial completion indexing
  • fixes the search completion tokenizer min_length parameter handling
  • fixes the geoid.parse() method to handle legacy identifiers (initialy / instead of : as separator)
  • fixes the zone.validity constraints
  • prepare for GeoZones 2019 (wikidata attribute)
  • prompt for countries in init command

To update, simply execute:

udata spatial load --drop /path/or/url/to/geozones/archive.tar.xz
udata spatial migrate 

A minimalistic Geozones archive with only countries is available on the Geozones release page: https://github.com/etalab/geozones/releases/download/2019.0/geozones-countries-2019-0-msgpack.tar.xz

@abulte
Copy link
Contributor

abulte commented Jun 7, 2019

Still multiple versions of a zone after deploying this on next:
Capture d'écran 2019-06-07 16 52 36

Maybe we need to reindex but:

udata@demo-02:~$ udata search index
➢ Initiliazing index "udata-2019-06-07-16-53"
➢ Indexing Dataset objects
ERROR: dictionary changed size during iteration
➢ Removing index udata-2019-06-07-16-53

@abulte
Copy link
Contributor

abulte commented Jun 7, 2019

After removing no_dereference here

for obj in qs.no_cache().no_dereference().timeout(False):
, next can be reindexed. But the zones are still there in multiple versions 🤷‍♂.

@abulte
Copy link
Contributor

abulte commented Jun 11, 2019

Reindexation fixed in #2195

@abulte abulte changed the title Geozones 2019 WIP: Geozones 2019 Jun 21, 2019
@noirbizarre noirbizarre changed the title WIP: Geozones 2019 Geozones 2019 Jun 21, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
@noirbizarre noirbizarre merged commit 1fb652a into opendatateam:master Jul 3, 2019
@noirbizarre noirbizarre deleted the geozone-2019 branch July 3, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants