Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive dataset feature #2172

Merged
merged 16 commits into from Jun 4, 2019
Merged

Archive dataset feature #2172

merged 16 commits into from Jun 4, 2019

Conversation

abulte
Copy link
Contributor

@abulte abulte commented May 29, 2019

  • dataset can be archived (for now) through a CLI command, one by one or massively
  • archived datasets should disappear from many lists (same as private) and the search index
  • they're still browsable but they have an "archived" tag and banner
  • opacity on the dataset container below the banner is set to 0.6

This also updates install.pip:

  • pin some dependencies that would break tests on a fresh install (click and Babel)
  • order requirements alphabetically
  • pin some potentially troublesome transient dependencies (we probably want some pyup PRs for those and have the same versions on every environment)

TODO

  • color scheme (?)
  • fade page to grey for more impact?
  • optionally post a comment on the dataset when archiving
  • banner wording: explain more
  • tests
$udata dataset archive datasets.txt
➢ Archiving datasets...
⚠ Dataset Base permanente des équipements already archived, bumping date
➢ Archived dataset Base permanente des équipements
⚠ Dataset Open DAMIR : base complète sur les dépenses d'assurance maladie inter régimes already archived, bumping date
➢ Archived dataset Open DAMIR : base complète sur les dépenses d'assurance maladie inter régimes
➢ Archived 2 datasets, 0 failed
$udata dataset archive_one 54903bfac751df244d6accbc
➢ Archived dataset Dépenses d' assurance maladie hors prestations hospitalières (données nationales)

archived (opacity: 0.7)

Capture d'écran 2019-05-29 16 31 23

Capture d'écran 2019-05-29 16 32 00

archived (opacity: 0.6)

Capture d'écran 2019-06-03 09 48 03

non archived

Capture d'écran 2019-05-29 16 41 13

Capture d'écran 2019-05-29 16 42 01

comment (optional)

Capture d'écran 2019-06-04 12 25 00

@abulte abulte changed the title WIP: Archive dataset feature Archive dataset feature Jun 4, 2019
@abulte abulte requested a review from taniki June 4, 2019 10:28
@taniki
Copy link
Contributor

taniki commented Jun 4, 2019

@abulte abulte merged commit 28fe147 into opendatateam:master Jun 4, 2019
@abulte abulte deleted the archive-dataset branch June 4, 2019 12:36
abulte added a commit that referenced this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants