Admin deletion consistency #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated HarvestersBoth alternatives have been merged ( strikethrough + proper status display)
The organization or user owning the harvester can the deleted state too
Admin homeDeleted reuses are displayed properly
Me and organizations tabsDatasets and reuses listing now display the deleted state
|
noirbizarre
changed the title
taniki
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays deleted item in the admin interface when its possible without a big API change.
It will be visible on:
System > HarvesterslistingMedashboardOrganizationdashboardThe deleted items are presented with a
<del>markup (introduce a newdeletable-textcell renderer):An alternative approach is to reuse the
visibilitycell renderer (no new cell renderer but wider display):NB: reuses test have been migrated while working on the initial specs, before the indexing part was removed. It can be submitted in another PR.
Related to #2216