Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin deletion consistency #2228

Merged

Conversation

@noirbizarre
Copy link
Member

noirbizarre commented Jul 4, 2019

This PR displays deleted item in the admin interface when its possible without a big API change.

It will be visible on:

  • System > Harvesters listing
  • Me dashboard
  • Organization dashboard

The deleted items are presented with a <del> markup (introduce a new deletable-text cell renderer):

screenshot-data xps-2019 07 04-15-46-53

Capture d’écran de 2019-07-04 15-47-44

An alternative approach is to reuse the visibility cell renderer (no new cell renderer but wider display):
screenshot-data xps-2019 07 04-15-37-52

NB: reuses test have been migrated while working on the initial specs, before the indexing part was removed. It can be submitted in another PR.

Related to #2216

noirbizarre added 4 commits Jul 4, 2019
noirbizarre added 5 commits Jul 4, 2019
…uses lists
@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Jul 4, 2019

Updated

Harvesters

Both alternatives have been merged ( strikethrough + proper status display)

screenshot-data xps-2019 07 04-18-00-11

The organization or user owning the harvester can the deleted state too

screenshot-data xps-2019 07 04-17-58-53

Admin home

Deleted reuses are displayed properly

screenshot-data xps-2019 07 04-17-46-30

Me and organizations tabs

Datasets and reuses listing now display the deleted state

screenshot-data xps-2019 07 04-17-44-28

@noirbizarre noirbizarre changed the title WIP: Admin deletion consistency Admin deletion consistency Jul 4, 2019
@noirbizarre noirbizarre requested a review from opendatateam/etalab Jul 4, 2019
@taniki
taniki approved these changes Jul 5, 2019
@taniki taniki referenced this pull request Jul 5, 2019
@noirbizarre noirbizarre merged commit 7f12886 into opendatateam:master Jul 8, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:gh2216-admin-deletion-consistency branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.