Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote resource race condition #2236

Conversation

@noirbizarre
Copy link
Member

commented Jul 9, 2019

This PR fix a case where filetype is set to null when filling the manual admin resource form by forcing the filetype value when enabling the manual form (using the link).

Fix #1987

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jul 9, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:gh1987-remote-resource-race-condition branch from 66f704a to dd9b593 Jul 9, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:gh1987-remote-resource-race-condition branch from dd9b593 to e4357ca Jul 9, 2019
@abulte
abulte approved these changes Jul 9, 2019
@noirbizarre noirbizarre merged commit 3ac293a into opendatateam:master Jul 9, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:gh1987-remote-resource-race-condition branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.