JS models loading state and error handling consistency #2247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure that every JS model:
loading
flag totrue
onfetch
/save
/update
(and so widgets properly display a spinner)save
/update
methods always accept an optional error handlersave
/update
methods always handle errors, even when no error handler is providedThe provided default error handler ensures:
loading
state is set back tofalse
(prevent infinite spinning on widgets)To improve the console fallback, a feedback pubsub needs to be implemented allowing views to listen on model errors and then notify the user.
This implements/fixes #2245 and ensures datagouv/data.gouv.fr#133 fix (#2246) does not get stuck on the spinner instead of properly display the form error