Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed daterange #2253

Merged

Conversation

@noirbizarre
Copy link
Member

commented Jul 23, 2019

This PR:

  • ensures that db.DateRange is always expressed and stored as a positive range (ie. start < end)
  • ensures that reversed data (stock data) still index properly (take date range absolute value for weight computing)
  • migrates stock data to swap start and end on reversed date ranges.
  • adds the missing db.DateRange tests
@noirbizarre noirbizarre requested a review from opendatateam/etalab Jul 23, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:dgfr140-reversed-daterange branch from f212b5e to 6517897 Jul 23, 2019
@bzg
bzg approved these changes Jul 24, 2019
noirbizarre added 4 commits Jul 23, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:dgfr140-reversed-daterange branch from 6517897 to 5f7c83f Jul 25, 2019
@noirbizarre noirbizarre merged commit 819ee2a into opendatateam:master Jul 25, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:dgfr140-reversed-daterange branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.