Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reversed daterange #2253

Merged
merged 4 commits into from Jul 25, 2019
Merged

Fix reversed daterange #2253

merged 4 commits into from Jul 25, 2019

Conversation

noirbizarre
Copy link
Contributor

This PR:

  • ensures that db.DateRange is always expressed and stored as a positive range (ie. start < end)
  • ensures that reversed data (stock data) still index properly (take date range absolute value for weight computing)
  • migrates stock data to swap start and end on reversed date ranges.
  • adds the missing db.DateRange tests

@noirbizarre noirbizarre added bug migration Requires or provide a data migration labels Jul 23, 2019
@noirbizarre noirbizarre requested a review from a team July 23, 2019 12:30
@noirbizarre noirbizarre merged commit 819ee2a into opendatateam:master Jul 25, 2019
@noirbizarre noirbizarre deleted the dgfr140-reversed-daterange branch July 25, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzg bzg bzg approved these changes

Assignees
No one assigned
Labels
bug migration Requires or provide a data migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @bzg