Improve oembed errors handling (no hidden error, CORS) #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it fix an issue that is currently referenced somewhere? If not, can you just add this issue and reference it in the PR message? |
|
Done 👍 |
bzg
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve oembed errors handling and fixes #2255.
This one has been detected while working on https://github.com/etalab/datagouv-search-indicator: one of the dataset have been removed (INSEE legacy SIRENE dataset) and this prevent from requesting oembed for this dataset (or more precisely from seing it's a 404 and the dataset does not exists anymore)
Note: this fixes specific error case on oembed but in order to have CORS on all errors a fix is required on flask-restplus