Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity.key filter to activity.atom feed #2293

Merged
merged 2 commits into from Aug 21, 2019

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Aug 21, 2019

The activity.atom feed can now be filtered like this: https://www.data.gouv.fr/fr/activity.atom?key=dataset:updated&key=dataset:created.

⚠️ This is suboptimal because it won't honour the feed_size setting. This is because we can not use key as a filter in the queryset. I can not see any better solution that is not over-engineered.

@abulte abulte requested a review from a team August 21, 2019 13:41
@teleboas teleboas self-requested a review August 21, 2019 13:51
Copy link
Member

@teleboas teleboas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abulte abulte merged commit 591f174 into opendatateam:master Aug 21, 2019
@abulte abulte deleted the filter-activity-feed branch August 21, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants