Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing published date from community ressources #2350

Merged
merged 5 commits into from Nov 19, 2019
Merged

Removing published date from community ressources #2350

merged 5 commits into from Nov 19, 2019

Conversation

quaxsze
Copy link
Collaborator

@quaxsze quaxsze commented Nov 18, 2019 •
edited

@quaxsze quaxsze changed the title Issue146 Removing published date from community ressources Nov 18, 2019
taniki
taniki reviewed Nov 18, 2019
View reviewed changes
js/front/dataset/index.js Outdated
published: resourceJsonLd.datePublished,
modified: resourceJsonLd.dateModified,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a bit useless

@abulte
Copy link
Contributor

abulte commented Nov 19, 2019

@quaxsze please add fix #<issue-number> in the PR comment and add an entry to the changelog under Current (cf rest of the file for format). Then you can merge 🎉

abulte
abulte approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR, congrats 🎂

@quaxsze quaxsze merged commit 989a79e into opendatateam:master Nov 19, 2019
@quaxsze quaxsze deleted the issue146 branch November 19, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniki taniki taniki approved these changes

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dates incohérentes
3 participants
@quaxsze @abulte @taniki