Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner option in settings #2492

Merged
merged 16 commits into from
Jun 16, 2020
Merged

Add banner option in settings #2492

Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
956fef3
adding some settings to display banners
JulienParis Jun 10, 2020
c6522fa
injecting banner in context in 2 places
JulienParis Jun 10, 2020
fd548e9
Merge branch 'master' into julien/banner
JulienParis Jun 10, 2020
d8de1a0
cleaning dev logs
JulienParis Jun 11, 2020
4298430
Merge branch 'julien/banner' of https://github.com/co-demos/udata int…
JulienParis Jun 11, 2020
76b5127
returning to older times where formatting strings were '{}'.format(..…
JulienParis Jun 11, 2020
4c98595
returning to older times where formatting strings were '{}'.format(..…
JulienParis Jun 11, 2020
a9ec623
returning to older times where formatting strings were '{}'.format(..…
JulienParis Jun 11, 2020
2e24d27
cleaning and deleting context injection for banner switch
JulienParis Jun 11, 2020
5076882
cleaning
JulienParis Jun 11, 2020
4c57079
cleaning
JulienParis Jun 11, 2020
4b659cb
cleaning
JulienParis Jun 11, 2020
d2b33a5
cleaning
JulienParis Jun 11, 2020
cdbea27
adding changelog
JulienParis Jun 11, 2020
bf212e9
adding changelog
JulienParis Jun 11, 2020
7de61e1
default settings for banner now we tested it in demo
JulienParis Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions udata/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,9 @@ class Defaults(object):

API_DOC_EXTERNAL_LINK = 'https://doc.data.gouv.fr/api/reference/'

# Global banner parameters
BANNER_ACTIVATED = True
JulienParis marked this conversation as resolved.
Show resolved Hide resolved
BANNER_HTML_FILENAME = 'banner-2020-06-datactivist-survey.html'
JulienParis marked this conversation as resolved.
Show resolved Hide resolved

class Testing(object):
'''Sane values for testing. Should be applied as override'''
Expand Down