Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cast if bytes in haverster's cron schedule #2493

Merged
merged 5 commits into from Jun 15, 2020
Merged

Add cast if bytes in haverster's cron schedule #2493

merged 5 commits into from Jun 15, 2020

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Jun 11, 2020 •
edited by abulte

fix #2490

@quaxsze quaxsze requested a review from abulte June 11, 2020 19:28
abulte
abulte reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests I think:

  • w/ json payload
  • w/o json payload

udata/harvest/api.py Outdated Show resolved Hide resolved
abulte
abulte reviewed Jun 15, 2020
View reviewed changes
udata/harvest/api.py Outdated Show resolved Hide resolved
udata/harvest/api.py Outdated Show resolved Hide resolved
@quaxsze quaxsze merged commit 01534c6 into opendatateam:master Jun 15, 2020
@quaxsze quaxsze deleted the issue2489 branch June 15, 2020 11:09
@abulte abulte mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong cron expression of harvester planification since py3 migration
2 participants
@quaxsze @abulte