Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks: base.modals and dataset.resource.card.extra-buttons #2514

Merged
merged 3 commits into from Jul 24, 2020
Merged

Add hooks: base.modals and dataset.resource.card.extra-buttons #2514

merged 3 commits into from Jul 24, 2020

Conversation

AntoineAugusti
Copy link
Contributor

@AntoineAugusti AntoineAugusti commented Jul 21, 2020

This PR adds a schema modal to resources that have specified a schema.

image

Content of the PR

Please review also the PR for the plugin.

Regarding hooks, I tried to stick to the naming convention in place

{{ hook('dataset.display.after-description') }}

I noticed the hooks mechanism is documented, but there is no documentation regarding where they are in templates or how to find them (do a search for {{ hook( in templates). I could add a note in the documentation if you'd like.

Before merging

  • Transfer udata-schema to etalab
  • Rename udata-schema to udata-schema-gouvfr
  • Revert etalab/udata-schema-gouvfr@83bbe9b (may need to bust cache on CircleCI)
  • Tag 0.1.0 for udata-schema-gouvfr

@AntoineAugusti AntoineAugusti changed the title Admin: add schema field to resource Add a modal for schemas on ressources Jul 21, 2020
@AntoineAugusti AntoineAugusti marked this pull request as ready for review July 21, 2020 18:15
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

  • Add a CHANGELOG entry
  • re hooks discoverability, I wonder if it would be useful (and not too painful to maintain) to have list of the available hooks in the docs

@AntoineAugusti
Copy link
Contributor Author

✅ for the CHANGELOG entry

For the documentation, I thought about adding a note like.

If you want to know which hooks are already available, search for {{ hook( in templates

@abulte abulte merged commit 35292e2 into opendatateam:master Jul 24, 2020
@abulte abulte changed the title Add a modal for schemas on ressources Add hooks: base.modals and dataset.resource.card.extra-buttons Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants