Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific method for resource removal #2534

Merged
merged 9 commits into from Sep 15, 2020
Merged

Add specific method for resource removal #2534

merged 9 commits into from Sep 15, 2020

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Sep 11, 2020 •
edited

fix #2530

@abulte abulte changed the title Add specific method for resoure removal Add specific method for resource removal Sep 11, 2020
@quaxsze quaxsze requested a review from abulte September 11, 2020 10:22
abulte
abulte reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests 😬

udata/core/dataset/models.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from abulte September 14, 2020 13:27
@quaxsze quaxsze merged commit f5ebfbb into opendatateam:master Sep 15, 2020
@quaxsze quaxsze deleted the cliStaticDelete branch September 15, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing a resource manually won't remove its file
2 participants
@quaxsze @abulte