Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent hosted resource's url from being set by client side #2545

Merged
merged 8 commits into from Oct 4, 2020
Merged

Prevent hosted resource's url from being set by client side #2545

merged 8 commits into from Oct 4, 2020

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Oct 2, 2020 •
edited

fix #2544

@quaxsze quaxsze requested a review from abulte October 2, 2020 15:07
abulte
abulte reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same for community resources.

There's some doc related to resources allowed domains that can be removed, I think.

udata/core/dataset/api.py Outdated Show resolved Hide resolved
udata/core/dataset/api.py Show resolved Hide resolved
udata/core/dataset/forms.py Outdated Show resolved Hide resolved
udata/tests/api/test_datasets_api.py Show resolved Hide resolved
udata/tests/api/test_datasets_api.py Outdated Show resolved Hide resolved
udata/tests/api/test_datasets_api.py Show resolved Hide resolved
@quaxsze quaxsze changed the title remove allowed domain Prevent hosted resource's url from bein set by client side Oct 2, 2020
abulte
abulte approved these changes Oct 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@abulte abulte changed the title Prevent hosted resource's url from bein set by client side Prevent hosted resource's url from being set by client side Oct 2, 2020
quaxsze and others added 3 commits October 3, 2020 18:45
@quaxsze @abulte
Update CHANGELOG.md
f015327 
Co-authored-by: Alexandre Bulté <alexandre@bulte.net>
@quaxsze @abulte
Update CHANGELOG.md
08dabe8 
Co-authored-by: Alexandre Bulté <alexandre@bulte.net>
@quaxsze @abulte
Update CHANGELOG.md
b94d120 
Co-authored-by: Alexandre Bulté <alexandre@bulte.net>
@quaxsze quaxsze merged commit 4dd3410 into opendatateam:master Oct 4, 2020
@quaxsze quaxsze deleted the fixResourceUrl branch October 4, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resource.fs_filename and resource.url are sometimes unsynced
2 participants
@quaxsze @abulte