Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the fs_filename logic when uploading a new resource on the data catalog #2547

Merged
merged 5 commits into from Oct 6, 2020
Merged

Using the fs_filename logic when uploading a new resource on the data catalog #2547

merged 5 commits into from Oct 6, 2020

Conversation

quaxsze
Copy link
Collaborator

@quaxsze quaxsze commented Oct 5, 2020 •
edited

fix #2542

@quaxsze quaxsze changed the title add fs_filename Using the fs_filename logic when uploading a new resource on the data catalog Oct 5, 2020
@quaxsze quaxsze requested a review from abulte October 5, 2020 10:20
abulte
abulte reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@quaxsze quaxsze requested a review from abulte October 5, 2020 16:54
@quaxsze quaxsze requested a review from abulte October 5, 2020 17:10
@quaxsze quaxsze merged commit 6fc4039 into opendatateam:master Oct 6, 2020
@quaxsze quaxsze deleted the issue2542 branch October 6, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data catalog: fs_filename not set
2 participants
@quaxsze @abulte