Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add length limit in forms #2585

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Add length limit in forms #2585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b522d2c
add length limit in forms
Dec 31, 2020
2fcaebd
update changelog
Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Current (in progress)

- Nothing yet
- Add title's and description's length limit in forms [#2585](https://github.com/opendatateam/udata/pull/2585)

## 2.5.0 (2020-11-30)

Expand Down
5 changes: 3 additions & 2 deletions udata/core/dataset/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ def map_legacy_frequencies(form, field):
class DatasetForm(ModelForm):
model_class = Dataset

title = fields.StringField(_('Title'), [validators.DataRequired()])
title = fields.StringField(
_('Title'), [validators.DataRequired(), validators.Length(max=350)])
acronym = fields.StringField(_('Acronym'),
description=_('An optional acronym'))
description = fields.MarkdownField(
_('Description'), [validators.DataRequired()],
_('Description'), [validators.DataRequired(), validators.Length(max=100000)],
description=_('The details about the dataset '
'(collection process, specifics...).'))
license = fields.ModelSelectField(
Expand Down
6 changes: 4 additions & 2 deletions udata/core/discussions/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ class DiscussionCreateForm(ModelForm):
model_class = Discussion

title = fields.StringField(_('Title'), [validators.DataRequired()])
comment = fields.StringField(_('Comment'), [validators.DataRequired()])
comment = fields.StringField(
_('Comment'), [validators.DataRequired(), validators.Length(max=50000)])
subject = fields.ModelField(_('Subject'), [validators.DataRequired()])
extras = fields.ExtrasField()


class DiscussionCommentForm(Form):
comment = fields.StringField(_('Comment'), [validators.DataRequired()])
comment = fields.StringField(
_('Comment'), [validators.DataRequired(), validators.Length(max=50000)])
close = fields.BooleanField(default=False)
4 changes: 2 additions & 2 deletions udata/core/organization/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
class OrganizationForm(ModelForm):
model_class = Organization

name = fields.StringField(_('Name'), [validators.DataRequired()])
name = fields.StringField(_('Name'), [validators.DataRequired(), validators.Length(max=350)])
acronym = fields.StringField(
_('Acronym'), description=_('Shorter organization name'))
description = fields.MarkdownField(
_('Description'), [validators.DataRequired()],
_('Description'), [validators.DataRequired(), validators.Length(max=20000)],
description=_('The details about your organization'))
url = fields.URLField(
_('Website'), description=_('The organization website URL'))
Expand Down
4 changes: 2 additions & 2 deletions udata/core/reuse/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ def check_url_does_not_exists(form, field):
class ReuseForm(ModelForm):
model_class = Reuse

title = fields.StringField(_('Title'), [validators.DataRequired()])
title = fields.StringField(_('Title'), [validators.DataRequired(), validators.Length(max=350)])
description = fields.MarkdownField(
_('Description'), [validators.DataRequired()],
_('Description'), [validators.DataRequired(), validators.Length(max=20000)],
description=_('The details about the reuse (build process, specifics, '
'self-critics...).'))
type = fields.SelectField(_('Type'), choices=list(REUSE_TYPES.items()))
Expand Down