Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dataset's created_at_internal date #2862

Merged
merged 18 commits into from Jul 27, 2023
Merged

Expose dataset's created_at_internal date #2862

merged 18 commits into from Jul 27, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Jul 3, 2023 •
edited

@quaxsze quaxsze requested a review from maudetes July 3, 2023 12:06
maudetes
maudetes reviewed Jul 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
udata/core/dataset/api_fields.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes July 12, 2023 13:28
maudetes
maudetes reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should apply the same for resources in this PR as well probably

udata/core/dataset/api_fields.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes July 24, 2023 09:25
@quaxsze quaxsze requested a review from maudetes July 25, 2023 10:00
maudetes
maudetes reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think internals are still missing at the dataset's level in apiv2, right?

maudetes
maudetes approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! 🙏

@quaxsze quaxsze merged commit 6d4f354 into master Jul 27, 2023
1 check passed
@quaxsze quaxsze deleted the ExposeCreated branch July 27, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] tri par date décroissante de création ne fonctionne pas
2 participants
@quaxsze @maudetes