Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/fix slug overflow with index suffix #2874

Merged
merged 3 commits into from Jul 25, 2023
Merged

Fix/fix slug overflow with index suffix #2874

merged 3 commits into from Jul 25, 2023

Conversation

maudetes
Copy link
Contributor

Alternative to #2873.

On slug generation, we have an issue with slugs that are duplicates and that need a suffix but are already at field.max_length.

This PR adds a check to crop slug if needed before adding suffix. It ensures that slug size is always <= field.max_length.

@maudetes maudetes mentioned this pull request Jul 25, 2023
Closed
tboye
tboye approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@tboye tboye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@maudetes maudetes requested a review from quaxsze July 25, 2023 12:05
@maudetes maudetes merged commit d255bfc into opendatateam:master Jul 25, 2023
1 check passed
@maudetes maudetes deleted the fix/fix-slug-overflow-with-index-suffix branch July 25, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboye tboye tboye approved these changes

@quaxsze quaxsze quaxsze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maudetes @tboye @quaxsze